Skip to content

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 24, 2025

Closes #15116

The cause for this issue is that _ belongs to the Common catagory in unicode instead of Latin like other ASCII alphabets. Since ASCII characters are always allowed, I just added an extra is_ascii() check to ensure this.

changelog: [disallowed_script_idents] fix FP on identifiers with _

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 24, 2025
@dswij dswij added this pull request to the merge queue Jun 28, 2025
Merged via the queue into rust-lang:master with commit 428208e Jun 28, 2025
11 checks passed
@wbcat
Copy link

wbcat commented Jun 29, 2025

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::disallowed_script_idents has false positive if there is an _ underscore in the ident
4 participants