fix option_if_let_else when Err variant is ignored
#14429
Conversation
|
r? @Manishearth rustbot has assigned @Manishearth. Use |
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Thanks for catching this. Since the issue had been closed and not reopened, this apparently flew under the radard.
Can you add a "Fixes #10335" in the PR description and squash your 3 commits into one?
dgulotta
force-pushed
the
fix_if_let_else
branch
from
4c7b478 to
9f49773
Compare
| LL + }) | ||
| | | ||
|
|
||
| error: use Option::map_or_else instead of an if let/else |
There was a problem hiding this comment.
issue: this lint says Option, and has Option in its name, we should probably not be linting here?
There was a problem hiding this comment.
I guess we already lint on Result here.
Tbh I'm not convinced of the value of this lint overall, we should probably have a team discussion about it, but separately to that we shoudl figure out if it should also handle Result in the same lint (and if so, it needs to be updated)
There was a problem hiding this comment.
That's a separate issue from fixing what currently exists.
This comment has been minimized.
This comment has been minimized.
|
Ping @dgulotta from triage. Can you rebase this please. |
dgulotta
force-pushed
the
fix_if_let_else
branch
from
9f49773 to
15ce209
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
the
S-waiting-on-review
This fixes an issue where clippy suggests passing a function that takes no arguments as the first argument of
Result::map_or_else. The function needs to take one argument. Example that triggers the issue: Playground linkFixes #10335.
changelog: [
option_if_let_else]: fix incorrect suggestion when the contents of anErrvariant are ignored