Skip to content

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Sep 28, 2024

Run ref_option (#13336) on the Clippy's own code, quiet a few hits. Per mentioned video, this may actually improve performance as well. Switch lint to pedantic


changelog: [ref_option]: upgrade lint to pedantic

@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 28, 2024
@nyurik
Copy link
Contributor Author

nyurik commented Sep 29, 2024

@rustbot r? @llogiq
this is a follow up to #13336

@rustbot rustbot assigned llogiq and unassigned dswij Sep 29, 2024
@llogiq
Copy link
Contributor

llogiq commented Sep 29, 2024

That makes sense to me. @bors r+

@bors
Copy link
Contributor

bors commented Sep 29, 2024

📌 Commit f7d5d9d has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 29, 2024

⌛ Testing commit f7d5d9d with merge dea325b...

bors added a commit that referenced this pull request Sep 29, 2024
Convert `&Option<T>` to `Option<&T>`

Run `ref_option` (#13336) on the Clippy's own code, quiet a few hits. Per mentioned video, this may actually improve performance as well.  Switch lint to `pedantic`

changelog [`ref_option`]: upgrade lint to `pedantic`
@bors
Copy link
Contributor

bors commented Sep 29, 2024

💔 Test failed - checks-action_test

@nyurik
Copy link
Contributor Author

nyurik commented Sep 29, 2024

Seems like some issue with the changelog?

@llogiq
Copy link
Contributor

llogiq commented Sep 29, 2024

@bors retry

@bors
Copy link
Contributor

bors commented Sep 29, 2024

⌛ Testing commit f7d5d9d with merge 061004a...

@bors
Copy link
Contributor

bors commented Sep 29, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 061004a to master...

@bors bors merged commit 061004a into rust-lang:master Sep 29, 2024
8 checks passed
@nyurik nyurik deleted the apply-ref-option branch September 29, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants