Skip to content

Conversation

jonboh
Copy link
Contributor

@jonboh jonboh commented Sep 13, 2023

changelog: [enum_variant_names]: fix single word variants preventing lint of later variant pre/postfixed with the enum name

fixes #11494

Single word variants prevented checking the check_enum_start and check_enum_end for being run on later variants

@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2023

r? @Centri3

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 13, 2023
@bors
Copy link
Contributor

bors commented Sep 24, 2023

☔ The latest upstream changes (presumably #11552) made this pull request unmergeable. Please resolve the merge conflicts.

@jonboh jonboh force-pushed the issue11494_enumvariants_order_affects_lint branch from c34e357 to ca4839a Compare October 7, 2023 16:58
@bors
Copy link
Contributor

bors commented Oct 18, 2023

☔ The latest upstream changes (presumably #11496) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@Centri3 Centri3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait. This looks good to me, after a rebase.

@jonboh jonboh force-pushed the issue11494_enumvariants_order_affects_lint branch from ca4839a to c51e2a0 Compare October 29, 2023 16:35
@Centri3
Copy link
Member

Centri3 commented Oct 31, 2023

Thank you! @bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2023

📌 Commit c51e2a0 has been approved by Centri3

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 31, 2023

⌛ Testing commit c51e2a0 with merge 3da80dc...

@bors
Copy link
Contributor

bors commented Oct 31, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing 3da80dc to master...

@bors bors merged commit 3da80dc into rust-lang:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enum_variant_names lint of a variant starting or ending with the name of the enum can depend on the order of the variants
4 participants