[useless_vec
]: add more tests and don't lint inside of macros
#11094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11084.
I realized that the fix I added in #11081 itself also causes an error in a suggestion when inside of a macro. Example:
Here it would suggest replacing
vec![1, 2]
with[x!()]
, because that's what the source callsite is (reminder: it does this to get the correct span ofx!()
for code likefor _ in vec![x!()]
), but that's wrong when inside macros, so I decided to make it not lint if the whole loop construct is inside a macro to avoid this issue.changelog: [
useless_vec
]: add more tests and don't lint inside of macrosr? @Alexendoo since these were your tests, I figured it makes most sense to assign you