[default_constructed_unit_structs]: do not lint on type alias paths
#10813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
xFrednet
approved these changes
May 26, 2023
Contributor
|
Looks good to me, thank you for the addition! 👍 @bors r+ The lint is new and will be released with 1.71 if the version attribute is correct. It might be, that this changes doesn't make it into master before the beta 1.71 branch is created. I'll therefore tag it as a potential back port. As this is a complexity lint, I could see this producing quite a few FPs @rustbot label +beta-nominated |
Contributor
rustbot
added
the
beta-nominated
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
flip1995
added
beta-accepted
Member
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 6, 2023
…ishearth [beta] Clippy beta backport Backported PRs: - rust-lang/rust-clippy#10813 - rust-lang/rust-clippy#10865 - rust-lang/rust-clippy#10873 - rust-lang/rust-clippy#10992 Those address bugs, that were either introduced with 1.71 and that we would like to address before they get into stable or bugs that were introduced in 1.70 and that we would like to be fixed in 1.71 already. Detailed arguments for the backports of those PRs are in the PRs (mostly). r? `@Mark-Simulacrum`
xFrednet
removed
the
beta-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10755.
Type aliases cannot be used as a constructor, so this lint should not trigger in those cases.
I also changed
clippy_utils::is_ty_aliasto also consider associated types since they kinda are type aliases too.changelog: [
default_constructed_unit_structs]: do not lint on type alias paths