Add a rudimentary json regex to get at information like endLine
#2566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
bors r+ Seems useful! Is there a specific case where one is forced to use JSON? |
bors bot
added a commit
that referenced
this pull request
Dec 15, 2019
2566: Add a rudimentary json regex to get at information like `endLine` r=matklad a=oli-obk Co-authored-by: Oliver Scherer <[email protected]>
Contributor
Author
I found the squiggly lines to be fairly confusing with the standard matchers. Especially around unused imports I kept getting the |
Contributor
Canceled |
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 15, 2019
2566: Add a rudimentary json regex to get at information like `endLine` r=matklad a=oli-obk Co-authored-by: Oliver Scherer <[email protected]>
Contributor
|
Just for the context, the long-term plan here is to move this from frontend (VS Code), to the language server proper (but still using an external command to get the errors). In this future setup, we should just parse JSON properly. |
Contributor
Author
|
Yea I'm totally aware this is just papering over the issue. Great to hear there's a plan for it. |
Contributor
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.