Improve stdio_transport: error handling & channel buffering #20479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
| let stdout = stdout(); | ||
| let mut stdout = stdout.lock(); | ||
| writer_receiver.into_iter().try_for_each(|it| { | ||
| for it in writer_receiver { |
There was a problem hiding this comment.
I think try_for_each is good enough here
| result | ||
| }) | ||
| let _ = drop_sender.send(it); // Fixed: was `let * = drop*sender.send(it);` | ||
| result?; // Propagate error instead of unwrap |
There was a problem hiding this comment.
We are not unwrapping error here in L25. The first error is propagated iterating through try_for_each
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.