internal: Make flycheck generational #20419
Merged
+148
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Aug 10, 2025
crates/rust-analyzer/src/flycheck.rs
Outdated
| @@ -138,36 +142,62 @@ pub(crate) struct FlycheckHandle { | |||
| sender: Sender<StateChange>, | |||
| _thread: stdx::thread::JoinHandle, | |||
| id: usize, | |||
| generation: Mutex<DiagnosticsGeneration>, | |||
There was a problem hiding this comment.
Given thats just a type alias might as well use an AtomicUsize here (with relaxed orderings)
There was a problem hiding this comment.
Or do we need to Syncness here in general? If not Cell<usize> ought to work
There was a problem hiding this comment.
I guess there won't be concurrent problems in general but we have this line that demands this to be sync:
I've used mutex just because some platforms might not support AtomicUsize but using it seems better since major platforms support it
Veykril
approved these changes
Aug 10, 2025
ShoyuVanilla
force-pushed
the
flyck-gen
branch
from
c4210b5 to
fc2190f
Compare
rustbot
removed
the
S-waiting-on-review
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19854