Skip to content

editor/code: Enable TypeScript's --useUnknownInCatchVariables option #15252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2023
Merged

editor/code: Enable TypeScript's --useUnknownInCatchVariables option #15252

merged 3 commits into from
Jul 10, 2023

Conversation

@tetsuharuohzeki
Copy link
Contributor

@tetsuharuohzeki tetsuharuohzeki commented Jul 10, 2023

This enables TypeScript's --useUnknownInCatchVariables.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2023
@lnicola
Copy link
Member

lnicola commented Jul 10, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jul 10, 2023

📌 Commit 444bc5b has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 10, 2023

⌛ Testing commit 444bc5b with merge 6f2e8aa...

@bors
Copy link
Contributor

bors commented Jul 10, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 6f2e8aa to master...

@bors bors merged commit 6f2e8aa into rust-lang:master Jul 10, 2023
@tetsuharuohzeki tetsuharuohzeki deleted the enable-unknonw-catch branch July 10, 2023 14:38
@tetsuharuohzeki
Copy link
Contributor Author

tetsuharuohzeki commented Jul 10, 2023

@lnicola thank you!

lnicola
lnicola reviewed Jul 10, 2023
View reviewed changes
editors/code/src/util.ts
}
})();

export async function sendRequestWithRetry<TParam, TRet>(
Copy link
Member

@lnicola lnicola Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lnicola lnicola lnicola approved these changes

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tetsuharuohzeki @lnicola @bors @rustbot