-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix link in syntax.md #13397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix link in syntax.md #13397
Conversation
|
Thanks! |
|
@bors r- |
|
It might also be nice to point these to a more recent commit. |
|
☀️ Try build successful - checks-actions |
|
Oh wait, the patch is backwards since the crates lost the |
|
Well, the hash is still pointing to the older crate names, but yeah, it should be updated. |
Co-authored-by: Laurențiu Nicola <[email protected]>
|
@zyctree what we're trying to say is that since the docs were written, the crates were renamed to drop the |
|
@lnicola I updated, using the commit you just mentioned. |
docs/dev/syntax.md
Outdated
|
|
||
| The things described are implemented in three places | ||
|
|
||
| * [rowan](https://github.com/rust-analyzer/rowan/tree/v0.9.0) -- a generic library for rowan syntax trees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe point this to v0.15.10?
docs/dev/syntax.md
Outdated
| * [syntax](https://github.com/rust-lang/rust-analyzer/tree/36a70b7435c48837018c71576d7bb4e8f763f501/crates/syntax) crate inside rust-analyzer which wraps `rowan` into rust-analyzer specific API. | ||
| Nothing in rust-analyzer except this crate knows about `rowan`. | ||
| * [parser](https://github.com/rust-lang/rust-analyzer/tree/cf5bdf464cad7ceb9a67e07985a3f4d3799ec0b6/crates/parser) crate parses input tokens into an `ra_syntax` tree | ||
| * [parser](https://github.com/rust-lang/rust-analyzer/tree/36a70b7435c48837018c71576d7bb4e8f763f501/crates/parser) crate parses input tokens into an `syntax` tree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * [parser](https://github.com/rust-lang/rust-analyzer/tree/36a70b7435c48837018c71576d7bb4e8f763f501/crates/parser) crate parses input tokens into an `syntax` tree | |
| * [parser](https://github.com/rust-lang/rust-analyzer/tree/36a70b7435c48837018c71576d7bb4e8f763f501/crates/parser) crate parses input tokens into a `syntax` tree |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
No description provided.