Skip to content

Conversation

@zyctree
Copy link
Contributor

@zyctree zyctree commented Oct 11, 2022

No description provided.

@Veykril
Copy link
Member

Veykril commented Oct 11, 2022

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Oct 11, 2022

📌 Commit 11a335d has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 11, 2022

⌛ Testing commit 11a335d with merge 885df92...

bors added a commit that referenced this pull request Oct 11, 2022
@lnicola
Copy link
Member

lnicola commented Oct 11, 2022

@bors r-

@lnicola
Copy link
Member

lnicola commented Oct 11, 2022

It might also be nice to point these to a more recent commit.

@bors
Copy link
Contributor

bors commented Oct 11, 2022

☀️ Try build successful - checks-actions
Build commit: 885df92 (885df924f10d6950ba17e3061b4206bb6ce9ddef)

@Veykril
Copy link
Member

Veykril commented Oct 11, 2022

Oh wait, the patch is backwards since the crates lost the ra_ prefix 😅 Shouldn't be reviewing first thing in the morning

@lnicola
Copy link
Member

lnicola commented Oct 11, 2022

Well, the hash is still pointing to the older crate names, but yeah, it should be updated.

Co-authored-by: Laurențiu Nicola <[email protected]>
@zyctree zyctree requested a review from lnicola October 13, 2022 04:44
@lnicola
Copy link
Member

lnicola commented Oct 15, 2022

@zyctree what we're trying to say is that since the docs were written, the crates were renamed to drop the ra_ prefix, as you can see in https://github.com/rust-lang/rust-analyzer/tree/36a70b7/crates. Can you update the docs to point to a newer commit and the correct crate names?

@zyctree
Copy link
Contributor Author

zyctree commented Oct 16, 2022

@lnicola I updated, using the commit you just mentioned.
And the beginning of docs says it is the status of 2020-01-09, maybe this date should be updated as well.


The things described are implemented in three places

* [rowan](https://github.com/rust-analyzer/rowan/tree/v0.9.0) -- a generic library for rowan syntax trees.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe point this to v0.15.10?

* [syntax](https://github.com/rust-lang/rust-analyzer/tree/36a70b7435c48837018c71576d7bb4e8f763f501/crates/syntax) crate inside rust-analyzer which wraps `rowan` into rust-analyzer specific API.
Nothing in rust-analyzer except this crate knows about `rowan`.
* [parser](https://github.com/rust-lang/rust-analyzer/tree/cf5bdf464cad7ceb9a67e07985a3f4d3799ec0b6/crates/parser) crate parses input tokens into an `ra_syntax` tree
* [parser](https://github.com/rust-lang/rust-analyzer/tree/36a70b7435c48837018c71576d7bb4e8f763f501/crates/parser) crate parses input tokens into an `syntax` tree
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [parser](https://github.com/rust-lang/rust-analyzer/tree/36a70b7435c48837018c71576d7bb4e8f763f501/crates/parser) crate parses input tokens into an `syntax` tree
* [parser](https://github.com/rust-lang/rust-analyzer/tree/36a70b7435c48837018c71576d7bb4e8f763f501/crates/parser) crate parses input tokens into a `syntax` tree

@lnicola
Copy link
Member

lnicola commented Oct 16, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 16, 2022

📌 Commit ea8b62f has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 16, 2022

⌛ Testing commit ea8b62f with merge 0531aab...

@bors
Copy link
Contributor

bors commented Oct 16, 2022

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 0531aab to master...

@bors bors merged commit 0531aab into rust-lang:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants