"implement missing members" assist uses incorrect lifetime name

[joseph-gio]

rust-analyzer version: rust-analyzer version: 0.3.1229-standalone (5c28ad193 2022-10-01)

rustc version: rustc 1.63.0 (4b91a6ea7 2022-08-08)

relevant settings: (eg. client settings, or environment variables like CARGO, RUSTUP_HOME or CARGO_HOME)

Given the following code:

pub trait MyTrait<'lifetime> {
    fn foo(&'lifetime self);
}

impl<'a> MyTrait<'a> for () {

}

Using the assist "implement missing members" results in the following:

impl<'a> MyTrait<'a> {
    fn foo(&'lifetime self) { // this should be &'a self
        todo!()
    }
}

[TheDoctor314]

I would like to look into this.

[ponyii]

"imlement default members", a closely-related assist, doesn't update neither lifetimes nor const params:

pub trait Foo<const N: usize> {
    const CONST: usize = N * 4;
}

impl<const AAA: usize> Foo<AAA> for () {
    const CONST: usize = N * 4;             // the assist adds `N` instead of `AAA`
}

[ponyii]

one more related problem - default types are not being transformed, e.g.:

mod m {
    pub struct S;

    pub trait Foo<T = S> {
        fn foo(&self, arg: &T) -> () {}
    }
}

impl m::Foo for () {
    fn foo(&self, arg: &S) -> () {}    // generated line with `S` instead of m::S
}