Lifetime elision #187
Merged
Lifetime elision #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Havvy
reviewed
Jan 6, 2018
| Mutable statics have the same restrictions as normal statics, except that the | ||
| type does not have to implement the `Sync` trait. | ||
|
|
||
| ## `'static` lifetime elision |
Contributor
There was a problem hiding this comment.
Not sure how, but it'd be nice for this page to say it's possible and link to the rules for it.
Contributor
Author
There was a problem hiding this comment.
There is at least a mention of this on the constant items page with a link.
matthewjasper
force-pushed
the
lifetime-elision
branch
from
bf6c2c3 to
d19507a
Compare
aturon
approved these changes
Feb 13, 2018
Contributor
aturon
left a comment
aturon
left a comment
There was a problem hiding this comment.
So sorry for the very late review! This looks great-- just a couple nits.
src/lifetime-elision.md
Outdated
| _default object lifetime bound_. These were defined in [RFC 599] and amended in | ||
| [RFC 1156]. | ||
|
|
||
| If the trait object is used as for a type argument of a generic type then the |
src/lifetime-elision.md
Outdated
| * If there is more than one bound from the containing type then an explicit | ||
| bound must be specified | ||
|
|
||
| Then the bounds on the trait are used: |
Contributor
There was a problem hiding this comment.
The text doesn't make clear the relationship between these bullets and the previous ones.
matthewjasper
force-pushed
the
lifetime-elision
branch
from
d19507a to
27d9924
Compare
Contributor
Author
|
changes made |
alercah
reviewed
Feb 13, 2018
src/lifetime-elision.md
Outdated
| In order to make common patterns more ergonomic, Rust allows lifetimes to be | ||
| *elided* in [function item], [function pointer] and [closure trait] signatures. | ||
| The following rules are used to infer lifetime parameters for elided lifetimes. | ||
| It is an error to elide lifetime parameters that cannot be infered. |
alercah
reviewed
Feb 13, 2018
src/lifetime-elision.md
Outdated
| type FunTrait = for<'a> Fn(&'a str) -> &'a str; // expanded | ||
| ``` | ||
|
|
||
| ## Defaults trait object lifetimes |
* Don't talk about a future feature * Add examples of elision in function pointers/traits * A rule for 'static bounds on trait objects * Static lifetime elision doesn't happen in function pointers/traits
matthewjasper
force-pushed
the
lifetime-elision
branch
from
27d9924 to
1014b0d
Compare
Contributor
Author
|
Thanks, fixed now. |
Contributor
|
cc @alercah |
Contributor
|
I don't see anything that looks off to me, but I also don't have the time for a detailed read. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR to add documentation for lifetimes (next will probably moving the relevant parts of the NLL RFC text into the reference when it gets stabilised).
This is mostly existing documentation from the nomicon/reference. Significant changes from that documentation:
implheaders)'staticis the preferred bound in trait objects with multiple bounds:const RESOLVED_STATIC: &Fn(&Foo, &Bar) -> &Bazis invalid, not inferred with'staticlifetimes. (This matches: http://rust-lang.github.io/rfcs/1623-static.html, so I'm guessing that it's just a docs issue)cc #9 (rust-lang/rfcs#141)