Skip to content

remove needs_drop impl #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2018
Merged

remove needs_drop impl #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ce0552
remove needs_drop impl
RalfJung Oct 1, 2018
eaff451
move 'cargo miri' test down so it is not the first thing testing star…
RalfJung Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ script:
xargo/build.sh &&
export MIRI_SYSROOT=~/.xargo/HOST
- |
# Test `cargo miri`
# run all tests with full mir
cargo test --release --all-features
- |
# test `cargo miri`
cd cargo-miri-test &&
if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
cargo miri -q -- -Zmiri-start-fn
Expand All @@ -50,12 +53,9 @@ script:
diff -u stdout.ref stdout.real &&
diff -u stderr.ref stderr.real
fi &&
# Test `cargo miri test`
# test `cargo miri test`
cargo miri test &&
cd ..
- |
# and run all tests with full mir
cargo test --release --all-features

notifications:
email:
Expand Down
2 changes: 1 addition & 1 deletion rust-toolchain
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nightly-2018-09-29
nightly-2018-10-01
10 changes: 0 additions & 10 deletions src/intrinsic.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,16 +272,6 @@ impl<'a, 'mir, 'tcx> EvalContextExt<'tcx> for EvalContext<'a, 'mir, 'tcx, super:
self.copy_op(args[1], ptr.into())?;
}

"needs_drop" => {
let ty = substs.type_at(0);
let env = ty::ParamEnv::reveal_all();
let needs_drop = ty.needs_drop(self.tcx.tcx, env);
self.write_scalar(
Scalar::from_bool(needs_drop),
dest,
)?;
}

"offset" => {
let offset = self.read_scalar(args[1])?.to_isize(&self)?;
let ptr = self.read_scalar(args[0])?.not_undef()?;
Expand Down