proper support for Assert MIR terminators
#1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
assert-panic
branch
from
234f59d to
2897a40
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
assert-panic
branch
2 times, most recently
from
6a7206a to
2cba42b
Compare
|
☔ The latest upstream changes (presumably #1092) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Dec 2, 2019
Miri engine: proper support for `Assert` MIR terminators This puts down the basis for rust-lang/miri#1070, and I also did some clean-up. The Miri side of this is at rust-lang/miri#1084. r? @oli-obk
Test diverging closure coercion Adds a test for rust-lang#1075. Depends on rust-lang/rust#66827.
RalfJung
force-pushed
the
assert-panic
branch
from
2cba42b to
0861f76
Compare
Requires generalizing the call_function helper to arbitrary Immediate arguments
RalfJung
force-pushed
the
assert-panic
branch
from
0861f76 to
2ef5ac1
Compare
|
@bors r+ |
|
📌 Commit 2ef5ac1 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 2, 2019
proper support for `Assert` MIR terminators Fixes #1070 Blocked on rust-lang/rust#66874
|
💔 Test failed - status-appveyor |
|
@bors r+ |
|
📌 Commit ce7b44b has been approved by |
bors
added a commit
that referenced
this pull request
Dec 2, 2019
proper support for `Assert` MIR terminators Fixes #1070 Blocked on rust-lang/rust#66874
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1070
Blocked on rust-lang/rust#66874