Skip to content

Hide the sidebar when collapsed to prevent browser search to find text from it #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
+53 −22
Merged

Hide the sidebar when collapsed to prevent browser search to find text from it #2725

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f942f38
Remove unused CSS class `sidebar-hidden`
GuillaumeGomez Jun 5, 2025
bcd4552
Hide the sidebar when collapsed to prevent browser search to find tex…
GuillaumeGomez Jun 5, 2025
16b99be
Update sidebar GUI test
GuillaumeGomez Jun 5, 2025
d1c0979
Fix animation bug in safari
ehuss Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/front-end/js/book.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,10 @@ aria-label="Show hidden lines"></button>';
/* To allow the sidebar expansion animation, we first need to put back the display. */
if (!sidebarCheckbox.checked) {
sidebar.style.display = '';
// Workaround for Safari skipping the animation when changing
// `display` and a transform in the same event loop. This forces a
// reflow after updating the display.
sidebar.offsetHeight;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very confused about this fix considering it does nothing. Dark magic.

}
});

Expand Down