-
Notifications
You must be signed in to change notification settings - Fork 1.2k
AIX: Fix the types of 'struct stat'/'struct stat64' fields 'st_*tim' #4597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would it make sense to add this as a define at https://github.com/xingxue-ibm/libc/blob/a861a0b0cb16dd0cfcb642c3d294fba754cf6df2/libc-test/build.rs#L5470? |
Yeah, I tried that before. Defining |
tgross35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM then. Wrote up #4598 in case it helps.
Thanks!
Thank you! |
|
@rustbot label +stable-nominated |
(backport <rust-lang#4597>) (cherry picked from commit cf82fdf)
(backport <rust-lang#4597>) (cherry picked from commit cf82fdf)
(backport <rust-lang#4597>) (cherry picked from commit cf82fdf)
Description
On AIX, when
_ALL_SOURCEis defined, thest_*timfields instruct stat/struct stat64usestruct st_timespec, whereas under POSIX, they usestruct timespec. This patch updates the type to align with the POSIX declaration.Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI