- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Add more windows time.h functions #4427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
54382cf    to
    735f3e0      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you double check the _wctime link name on windows-gnu? Looks like that is causing a failure
735f3e0    to
    fca29e6      
    Compare
  
    | Yup, removing it fixed the issue. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, And I double checked the signatures. Documentation links, just for the the record:
fca29e6    to
    35a32a7      
    Compare
  
    | Thanks both! | 
(cherry picked from commit 35a32a7) (backport <rust-lang#4427>)
(cherry picked from commit 35a32a7) (backport <rust-lang#4427>)
(backport <rust-lang#4427>) (cherry picked from commit 35a32a7)
(backport <rust-lang#4427>) (cherry picked from commit 35a32a7)
(backport <rust-lang#4427>) (cherry picked from commit 35a32a7)
Description
Adds some windows time functions
Related issue: #1245
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see rust-lang/libc#3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI