Resolve various CI issues #4254

tgross35 · 2025-01-27T07:04:49Z

Fix the missing_abi lint

Recent versions of Rust require the ABI always be specified for extern functions, whereas it historically defaulted to extern "C". Fix a few cases where this lint now gets raised by specifying extern "C".

Disable RUST_BACKTRACE for FreeBSD CI

Having this environment variable set causes a segfault rust-lang/rust#132185. Just disable backtraces for now.

FreeBSD: Add the new st_filerev field to stat32 for FreeBSD 15

This field appears to have been added recently freebsd/freebsd-src@b4663a8.

Temporarily disable powerpc-unknown-linux-gnu tests

As mentioned in 1, this test has started to fail for unclear reasons. Disable this until it can be investigated further.

rustbot · 2025-01-27T07:04:52Z

@tgross35: no appropriate reviewer found, use r? to override

Recent versions of Rust require the ABI always be specified for `extern` functions, whereas it historically defaulted to `extern "C"`. Fix a few cases where this lint now gets raised by specifying `extern "C"`.

tgross35 · 2025-01-27T07:22:06Z

error: linker stderr: ld: ignoring duplicate libraries: '-lc', '-lm'

This must be new

tgross35 · 2025-01-27T07:27:28Z

On ppc error: linker stderr: /usr/lib/gcc-cross/powerpc-linux-gnu/13/../../../../powerpc-linux-gnu/bin/ld: bss-plt forced due to /checkout/target/powerpc-unknown-linux-gnu/debug/deps/libc-1418d2c3ba41e79e.bn05wnafzhhjwo0wbk74h1tni.rcgu.o

Windows: Warning: corrupt .drectve at end of def file

tgross35 · 2025-01-27T07:41:16Z

That warning gets downgraded in rust-lang/rust#136098, we can wait for that.

tgross35 · 2025-01-28T01:55:13Z

The FreeBSD failures look like rust-lang/cargo#15092

pheki · 2025-02-05T03:53:14Z

For the FreeBSD jobs, if rust-lang/cargo#15092 is the same issue, maybe disabling backtraces on cirrus could work?

ci/run.sh defaults it to 1, but we should be able to explicitly pass 0 on it on .cirrus.yml:

diff --git a/.cirrus.yml b/.cirrus.yml
index 656696c82..798a36dcc 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -27,5 +27,5 @@ task:
     - if [ "$TARGET" = "i686-unknown-freebsd" ]; then rustup target add i686-unknown-freebsd; fi
   test_script:
     - . $HOME/.cargo/env
-    - LIBC_CI=1 sh ci/run.sh $TARGET
+    - LIBC_CI=1 RUST_BACKTRACE=0 sh ci/run.sh $TARGET
     - sh ci/run.sh $TARGET

tgross35 · 2025-02-05T06:05:23Z

Thanks for the writeup. I do plan to try that out, just haven't had a chance to circle back to this yet.

Having this environment variable set causes a segfault [1]. Just disable backtraces for now. [1]: rust-lang/rust#132185

This field appears to have been added recently [1]. [1]: freebsd/freebsd-src@b4663a8

tgross35 · 2025-02-05T10:08:16Z

Fyi @asomers the third commit here adds a field to stat32 that seems to be new in FreeBSD 15 freebsd/freebsd-src@b4663a8.

tgross35 · 2025-02-05T10:09:21Z

No idea what the PPC failure is about

     Running test/main.rs (target/powerpc-unknown-linux-gnu/debug/deps/main-cbb4a863e45d0841)
error: test failed, to rerun pass `-p libc-test --test main`

Caused by:
  process didn't exit successfully: `qemu-ppc -L /usr/powerpc-linux-gnu /checkout/target/powerpc-unknown-linux-gnu/debug/deps/main-cbb4a863e45d0841 --skip check_style` (signal: 4, SIGILL: illegal instruction)

I am going to disable that for now in order to get CI unstuck.

As mentioned in [1], this test has started to fail for unclear reasons. Disable this until it can be investigated further. [1]: rust-lang#4254 (comment)

Recent versions of Rust require the ABI always be specified for `extern` functions, whereas it historically defaulted to `extern "C"`. Fix a few cases where this lint now gets raised by specifying `extern "C"`. (backport <rust-lang#4254>) (cherry picked from commit c9a71dc)

Having this environment variable set causes a segfault [1]. Just disable backtraces for now. [1]: rust-lang/rust#132185 (backport <rust-lang#4254>) (cherry picked from commit 8d8a199)

This field appears to have been added recently [1]. [1]: freebsd/freebsd-src@b4663a8 (backport <rust-lang#4254>) (cherry picked from commit f691a1a)

As mentioned in [1], this test has started to fail for unclear reasons. Disable this until it can be investigated further. [1]: rust-lang#4254 (comment) (backport <rust-lang#4254>) (cherry picked from commit eb7045b)

Recent versions of Rust require the ABI always be specified for `extern` functions, whereas it historically defaulted to `extern "C"`. Fix a few cases where this lint now gets raised by specifying `extern "C"`. (backport <rust-lang#4254>) (cherry picked from commit c9a71dc)

Having this environment variable set causes a segfault [1]. Just disable backtraces for now. [1]: rust-lang/rust#132185 (backport <rust-lang#4254>) (cherry picked from commit 8d8a199)

This field appears to have been added recently [1]. [1]: freebsd/freebsd-src@b4663a8 (backport <rust-lang#4254>) (cherry picked from commit f691a1a)

As mentioned in [1], this test has started to fail for unclear reasons. Disable this until it can be investigated further. [1]: rust-lang#4254 (comment) (backport <rust-lang#4254>) (cherry picked from commit eb7045b)

tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jan 27, 2025

rustbot added the S-waiting-on-review label Jan 27, 2025

Fix the missing_abi lint

c9a71dc

Recent versions of Rust require the ABI always be specified for `extern` functions, whereas it historically defaulted to `extern "C"`. Fix a few cases where this lint now gets raised by specifying `extern "C"`.

tgross35 force-pushed the fix-missing-abi branch from f381666 to c9a71dc Compare January 27, 2025 07:05

tgross35 enabled auto-merge January 27, 2025 07:05

tgross35 mentioned this pull request Jan 27, 2025

Remove pthread_set_name_np from NuttX #4251

Merged

3 tasks

rustbot added the A-CI Area: CI-related items label Jan 27, 2025

tgross35 mentioned this pull request Jan 27, 2025

Tracking Issue for enabling the linker-messages lint by default rust-lang/rust#136096

Open

16 tasks

devnexen mentioned this pull request Jan 27, 2025

Fix macros attempt. #4253

Closed

This was referenced Jan 27, 2025

hurd: Fix CMSG_DATA on 64bit systems #4240

Merged

Add in the sigtrap si_codes #4225

Merged

tgross35 added this pull request to the merge queue Jan 28, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2025

This was referenced Jan 30, 2025

Use Rust union types #2056

Merged

Apply modulo 256 to BSD WEXITSTATUS #4213

Merged

Disable RUST_BACKTRACE for FreeBSD CI

8d8a199

Having this environment variable set causes a segfault [1]. Just disable backtraces for now. [1]: rust-lang/rust#132185

tgross35 force-pushed the fix-missing-abi branch from 63d0b62 to 8d8a199 Compare February 5, 2025 08:01

rustbot added the O-unix label Feb 5, 2025

tgross35 changed the title ~~Fix the missing_abi lint~~ Resolve various CI issues Feb 5, 2025

FreeBSD: Add the new st_filerev field to stat32 for FreeBSD 15

f691a1a

This field appears to have been added recently [1]. [1]: freebsd/freebsd-src@b4663a8

Temporarily disable powerpc-unknown-linux-gnu tests

eb7045b

As mentioned in [1], this test has started to fail for unclear reasons. Disable this until it can be investigated further. [1]: rust-lang#4254 (comment)

tgross35 force-pushed the fix-missing-abi branch from f436699 to eb7045b Compare February 5, 2025 10:10

tgross35 added this pull request to the merge queue Feb 5, 2025

Merged via the queue into rust-lang:main with commit 9ea78dc Feb 5, 2025
44 checks passed

tgross35 deleted the fix-missing-abi branch February 5, 2025 11:03

tgross35 mentioned this pull request Feb 14, 2025

[0.2] Backports #4266

Merged

github-actions bot mentioned this pull request Feb 14, 2025

chore: release v0.2.170 #4219

Merged

tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Feb 14, 2025

github-actions bot mentioned this pull request Feb 16, 2025

chore: release v0.2.170 yuki0iq/libc#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Resolve various CI issues #4254

Resolve various CI issues #4254

Uh oh!

tgross35 commented Jan 27, 2025 •

edited

Loading

Uh oh!

rustbot commented Jan 27, 2025

Uh oh!

tgross35 commented Jan 27, 2025

Uh oh!

tgross35 commented Jan 27, 2025 •

edited

Loading

Uh oh!

tgross35 commented Jan 27, 2025

Uh oh!

tgross35 commented Jan 28, 2025

Uh oh!

Uh oh!

pheki commented Feb 5, 2025 •

edited

Loading

Uh oh!

tgross35 commented Feb 5, 2025

Uh oh!

tgross35 commented Feb 5, 2025

Uh oh!

tgross35 commented Feb 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Resolve various CI issues #4254

Resolve various CI issues #4254

Uh oh!

Conversation

tgross35 commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 27, 2025

Uh oh!

tgross35 commented Jan 27, 2025

Uh oh!

tgross35 commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Jan 27, 2025

Uh oh!

tgross35 commented Jan 28, 2025

Uh oh!

Uh oh!

pheki commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Feb 5, 2025

Uh oh!

tgross35 commented Feb 5, 2025

Uh oh!

tgross35 commented Feb 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tgross35 commented Jan 27, 2025 •

edited

Loading

tgross35 commented Jan 27, 2025 •

edited

Loading

pheki commented Feb 5, 2025 •

edited

Loading