[AIX] Use sa_sigaction instead of the union

[xingxue-ibm]

Description

The current libc crate implementation for AIX defines struct sigaction as containing a union sa_union with two members: __su_handler and __su_sigaction. This mirrors the struct sigaction definition in the AIX system header. Consequently, any reference to sa_sigaction in Rust code, whether in shipped crates or user code, must be replaced with sa_union.__su_sigaction for AIX. Additionally, the types of these two union members are declared as function pointers rather than sighandler_t (i.e., usize), as is the case on other platforms. This discrepancy causes compiler errors when sighandler_t is used as the type for signal handlers. Other operating systems, such as Linux, also define a union for sa_handler and sa_sigaction in struct sigaction. However, the libc crate implementations on these platforms define sa_sigaction directly as a member of struct sigaction rather than as part of a union. This patch modifies the libc crate implementation for AIX to define sa_sigaction as a direct member of struct sigaction, aligning it with implementations for other similar platforms. We will also update affected crates and test cases to reflect this change.

Sources

Checklist

• Relevant tests in libc-test/semver have been updated
• No placeholder or unstable values like *LAST or *MAX are
  included (see #3131)
• Tested locally (cd libc-test && cargo test --target mytarget);
  especially relevant for platforms that may not be checked in CI

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[xingxue-ibm]

close GH-4249

[daltenty]

LGTM from the AIX perspective. This makes the implementation common with what is done on other targets

[tgross35]

Is this something that should be changed once we are able to use unions (1.0)? If so, could you label the comment FIXME(union)?

[xingxue-ibm]

Changed as suggested, thanks so much!

[tgross35]

Needs a rebase but the change LGTM. @xingxue-ibm @daltenty do you want this in a stable release since it is a breaking change?

[xingxue-ibm]

Needs a rebase but the change LGTM. @xingxue-ibm @daltenty do you want this in a stable release since it is a breaking change?

Done rebasing. Yeah, it would be great if this change could be included in a stable release. What do you think, @daltenty?

[tgross35]

I'll wait for @daltenty to ack before backporting. Just add the label back (@rustbot label +stable-nominated) so I pick it up if you do want it in stable.

[daltenty]

Thanks! Yep, it'd help a lot of crates to have this in stable as well. It is a breaking change, but honestly it fixes more crates than it breaks since it makes the member access uniform to what we expect from other platforms.

@rustbot label +stable-nominated