-
Couldn't load subscription status.
- Fork 1.2k
Update esp-idf time flag #3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update esp-idf time flag #3993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change makes sense. Do you want this in 0.2 stable, considering it is a breaking change?
Yes, our idea is to get it into 0.2 stable. cc: @ivmarkov |
(backport <rust-lang#3993>) (cherry picked from commit 7bd7276)
Also, note the espidf_time32 flag, added per rust-lang/libc#3993
Description
This PR updates the ESP-IDF time flag, instead of having a
espidf_time64, we will have aespidf_time32flag.espidf_time64was enabling support for ESP-IDF 5 (latest stable), whileespidf_time32enables support for ESP-IDF 4 (which is now end of life). So making ESP-IDF 4 the opt-in and having ESP-IDF 5 enabled by default makes sense.See esp-rs/esp-idf-sys#306 (comment) for more information.
cc: @ivmarkov
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI