Don't import std::string::String #3599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../std/src/prelude/mod.rs:105:13 | = note: the item `String` is already defined here | = note: `#[warn(unused_imports)]` on by default
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
JohnTitor
approved these changes
Feb 28, 2024
tgross35
added
the
stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 13, 2024
.../std/src/prelude/mod.rs:105:13 | = note: the item `String` is already defined here | = note: `#[warn(unused_imports)]` on by default (backport <rust-lang#3599>) (cherry picked from commit 6025890)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 13, 2024
.../std/src/prelude/mod.rs:105:13 | = note: the item `String` is already defined here | = note: `#[warn(unused_imports)]` on by default (backport <rust-lang#3599>) (cherry picked from commit 6025890)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.../std/src/prelude/mod.rs:105:13
|
= note: the item
Stringis already defined here|
= note:
#[warn(unused_imports)]on by default