Skip to content

Remove cfg hacks for old MSRV #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2024
Merged

Remove cfg hacks for old MSRV #3525

merged 1 commit into from
Jan 8, 2024

Conversation

@JohnTitor
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2024

@JohnTitor: no appropriate reviewer found, use r? to override

@rustbot
Copy link
Collaborator

rustbot commented Jan 7, 2024

Some changes occurred in OpenBSD module

cc @semarie

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@JohnTitor JohnTitor force-pushed the rm-old-cfg-hacks branch 2 times, most recently from 4ccb290 to 1ef7e87 Compare January 7, 2024 19:22
@JohnTitor
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jan 7, 2024

📌 Commit 1ef7e87 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 7, 2024

⌛ Testing commit 1ef7e87 with merge a5dfaa3...

bors added a commit that referenced this pull request Jan 7, 2024
@bors
Auto merge of #3525 - JohnTitor:rm-old-cfg-hacks, r=JohnTitor
a5dfaa3 
Remove cfg hacks for old MSRV
@bors
Copy link
Contributor

bors commented Jan 7, 2024

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2024

📌 Commit 061a7e3 has been approved by JohnTitor

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jan 8, 2024
@bors
Auto merge of #3525 - JohnTitor:rm-old-cfg-hacks, r=JohnTitor
6478ec6 
Remove cfg hacks for old MSRV
@bors
Copy link
Contributor

bors commented Jan 8, 2024

⌛ Testing commit 061a7e3 with merge 6478ec6...

@bors
Copy link
Contributor

bors commented Jan 8, 2024

💔 Test failed - checks-actions

@semarie
Copy link
Contributor

semarie commented Jan 8, 2024

FYI, it is fine on openbsd

@JohnTitor
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2024

📌 Commit ba4892f has been approved by JohnTitor

It is now in the queue for this repository.

@JohnTitor
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2024

📌 Commit 7a4517b has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 8, 2024

⌛ Testing commit 7a4517b with merge 298b0a7...

bors added a commit that referenced this pull request Jan 8, 2024
@bors
Auto merge of #3525 - JohnTitor:rm-old-cfg-hacks, r=JohnTitor
298b0a7 
Remove cfg hacks for old MSRV
@bors
Copy link
Contributor

bors commented Jan 8, 2024

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jan 8, 2024

📌 Commit e2e6fd6 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 8, 2024

⌛ Testing commit e2e6fd6 with merge a0d9be1...

@bors
Copy link
Contributor

bors commented Jan 8, 2024

☀️ Test successful - checks-actions, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing a0d9be1 to main...

@bors bors merged commit a0d9be1 into rust-lang:main Jan 8, 2024
@bors bors mentioned this pull request Jan 8, 2024
Closed
@JohnTitor JohnTitor deleted the rm-old-cfg-hacks branch January 8, 2024 09:06
This was referenced Jan 8, 2024
Merged
Closed
bjorn3
bjorn3 reviewed Jan 8, 2024
View reviewed changes
Cargo.toml
description = """
Raw FFI bindings to platform libraries like libc.
"""
rust-version = "1.71.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update to the 2021 edition too? The 2015 edition has quite different name resolution rules that are foreign for people having learned rust in 2018 or later as well as anyone who has forgotten the 2015 rules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, we should migrate to it, yeah.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the problem is that ctest2 uses a quite old librustc_syntax fork and doesn't support newer syntax at all. We have to rewrite ctest2 first :(

@faho faho mentioned this pull request May 10, 2024
Open
@djc
Copy link
Contributor

djc commented May 10, 2024

It's very surprising to me that there's no discussion or reference here to what the new MSRV should be. Was this discussed in an issue? If so, please link the issue in the PR description.

In my opinion it would be nice to stick to 1.63 for the time being, matching Tokio and a bunch of other downstreams that would like to support stable Debian.

@TheBlueMatt
Copy link

TheBlueMatt commented May 10, 2024 •
edited
Loading

I'm incredibly surprised that libc decided here to break downstream (which is basically the entire Rust ecosystem) here, especially with still no support for fixing the breakage via automated pinning/downgrade in the impacted versions of cargo.

@Amanieu
Copy link
Member

Amanieu commented May 10, 2024

This change only applies to the v1.0 branch (main) which is not released yet. The v0.2 branch still has the old MSRV.

@ChrisDenton
Copy link
Member

Maybe the version should be changed on the main branch to avoid further confusion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bjorn3 bjorn3 bjorn3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-waiting-on-bors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@JohnTitor @rustbot @bors @semarie @djc @TheBlueMatt @Amanieu @ChrisDenton @bjorn3