Make access inner of futures::io::{BufReader,BufWriter} not require inner trait bound #2848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'm in favor of accepting this as std::io::BufReader does the same thing. That said, I think it would be good to remove the bound from not only these accessors, but also from non constructor methods such as |
|
I totally agree, I do the same thing on other non custructor methods just now. |
taiki-e
reviewed
Mar 31, 2024
…BufReader,BufWriter} not require inner trait bound
taiki-e
pushed a commit
that referenced
this pull request
Oct 5, 2024
…t require inner trait bound (#2848)
Merged
taiki-e
pushed a commit
that referenced
this pull request
Oct 5, 2024
…t require inner trait bound (#2848)
taiki-e
pushed a commit
that referenced
this pull request
Oct 5, 2024
…t require inner trait bound (#2848)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, accessing the inner of
futures::io::{BufReader, BufWriter}requires that the inner type implementsAsyncReadorAsyncWrite. This constraint is much stricter than the semantics of inner access require. Removing the trait bound would be helpful in cases where pass-through functions simply obtain a reference to the inner I/O object for further use, without having to specify the inner trait bound explicitly.