Format most crates with rustfmt #2338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
By the way, one of the reasons for doing this is that it's painful to review a PR that contains a lot of irrelevant format changes like #2283 |
Member
Author
I don't like the rustfmt to inflate the code. Perhaps it makes sense to use |
Member
Author
Hmm, the reason futures-channel doesn't conflict is actually due to a bug where rustfmt can't format the code contained in the module inside the macro. I need to exclude futures-channel from the list. |
Member
Author
|
This blocks a lot of other work I want to do, so I'll close this for now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This formats the following crates with rustfmt.
futures-util and futures-channel conflicts with many of other PRs and will not be formatted in this PR.
futures-executor also have some PR, but I plan to close them (I'll describe in detail when closing them).