futures-util: Migrate from pin-project to pin-project-lite #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
compile time with no-default-features +
after (this pr):
Note: compile time with default features doesn't change much, as pin-project-lite readme says. |
taiki-e
force-pushed
the
pin-project-lite
branch
from
7213cdc to
8f4c9d3
Compare
taiki-e
force-pushed
the
pin-project-lite
branch
from
8f4c9d3 to
9bf8bc3
Compare
cramertj
approved these changes
Dec 9, 2020
|
@cramertj Thanks for the review! |
This was referenced Jan 8, 2021
Merged
This was referenced Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE(taiki-e): It's recommended to see #2170 (comment), if you are considering to do the same as this PR.
pin-project-lite0.2 supports enum. However, unfortunately, some enums (Either,(Try)MaybeDone) that require pin-projection used in futures-util have tuple variants and are also public APIs, so, we cannot use pin-project-lite for these enums.futures-testalso depends on pin-project, but this PR doesn't touch that as that needs support for custom Drop implementation (taiki-e/pin-project-lite#25) andfutures-testis a crate intended to be used as a dev-dependency.Closes #2170