Skip to content

run cargo update, update to rust 1.89.0 #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

syphar
Copy link
Member

@syphar syphar commented Aug 13, 2025

last time we tried, awesomized/crc-fast-rust#14 lead to a SIGKILL when running our tests, and I assume this would have happened on the server too.

The library that is using crc-fast is aws-smithy-checksums:

crc-fast v1.3.0
└── aws-smithy-checksums v0.63.7
    └── aws-sdk-s3 v1.103.0
        └── docs-rs v0.6.0 (/Users/syphar/src/rust-lang/docs.rs)

Which actually downgraded the crc-fast library to work around this bug: smithy-lang/smithy-rs#4264

So now we can try the upgrade again, when we also run cargo update:

  Locking 48 packages to latest Rust 1.89.0 compatible versions
    Updating arbitrary v1.4.1 -> v1.4.2
    Updating async-trait v0.1.88 -> v0.1.89
    Updating aws-config v1.8.4 -> v1.8.5
    Updating aws-sdk-cloudfront v1.89.0 -> v1.92.0
    Updating aws-sdk-s3 v1.101.0 -> v1.103.0
    Updating aws-sdk-sso v1.79.0 -> v1.81.0
    Updating aws-sdk-ssooidc v1.80.0 -> v1.82.0
    Updating aws-sdk-sts v1.81.0 -> v1.84.0
    Updating aws-smithy-checksums v0.63.6 -> v0.63.7
    Updating aws-smithy-eventstream v0.60.10 -> v0.60.11
    Updating aws-smithy-http-client v1.0.6 -> v1.1.0
    Updating aws-smithy-runtime v1.8.6 -> v1.9.0
    Updating aws-smithy-runtime-api v1.8.7 -> v1.9.0
    Updating bitflags v2.9.1 -> v2.9.2
    Updating cc v1.2.32 -> v1.2.33
    Updating cfg-if v1.0.1 -> v1.0.3
    Updating clap v4.5.44 -> v4.5.45
    Updating clap_derive v4.5.41 -> v4.5.45
 Downgrading crc-fast v1.4.0 -> v1.3.0 (available: v1.4.0)
    Updating curl v0.4.48 -> v0.4.49
    Updating curl-sys v0.4.82+curl-8.14.1 -> v0.4.83+curl-8.15.0
    Updating derive_arbitrary v1.4.1 -> v1.4.2
    Updating filetime v0.2.25 -> v0.2.26
    Updating form_urlencoded v1.2.1 -> v1.2.2
    Updating gix-actor v0.35.3 -> v0.35.4
    Updating gix-fs v0.16.0 -> v0.16.1
    Updating gix-object v0.50.1 -> v0.50.2
    Updating gix-ref v0.53.0 -> v0.53.1
    Updating hyper v1.6.0 -> v1.7.0
    Updating idna v1.0.3 -> v1.1.0
    Updating percent-encoding v2.3.1 -> v2.3.2
    Updating prettyplease v0.2.36 -> v0.2.37
    Updating proc-macro2 v1.0.97 -> v1.0.101
    Updating quick-xml v0.38.1 -> v0.38.2
    Updating rayon v1.10.0 -> v1.11.0
    Updating rayon-core v1.12.1 -> v1.13.0
    Updating reqwest v0.12.22 -> v0.12.23
    Updating serde_json v1.0.142 -> v1.0.143
    Updating syn v2.0.104 -> v2.0.106
    Updating tempfile v3.20.0 -> v3.21.0
    Updating thiserror v2.0.14 -> v2.0.16
    Updating thiserror-impl v2.0.14 -> v2.0.16
    Updating tinyvec v1.9.0 -> v1.10.0
    Updating ureq v3.0.12 -> v3.1.0
    Updating ureq-proto v0.4.2 -> v0.5.0
    Updating url v2.5.4 -> v2.5.6
    Removing webpki-root-certs v0.26.11
    Updating winapi-util v0.1.9 -> v0.1.10
    Updating zip v4.3.0 -> v4.4.0

@syphar syphar requested a review from a team as a code owner August 13, 2025 12:41
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Aug 13, 2025
@syphar syphar self-assigned this Aug 13, 2025
@syphar syphar marked this pull request as draft August 13, 2025 12:42
syphar added 2 commits August 21, 2025 23:44
     Locking 48 packages to latest Rust 1.89.0 compatible versions
    Updating arbitrary v1.4.1 -> v1.4.2
    Updating async-trait v0.1.88 -> v0.1.89
    Updating aws-config v1.8.4 -> v1.8.5
    Updating aws-sdk-cloudfront v1.89.0 -> v1.92.0
    Updating aws-sdk-s3 v1.101.0 -> v1.103.0
    Updating aws-sdk-sso v1.79.0 -> v1.81.0
    Updating aws-sdk-ssooidc v1.80.0 -> v1.82.0
    Updating aws-sdk-sts v1.81.0 -> v1.84.0
    Updating aws-smithy-checksums v0.63.6 -> v0.63.7
    Updating aws-smithy-eventstream v0.60.10 -> v0.60.11
    Updating aws-smithy-http-client v1.0.6 -> v1.1.0
    Updating aws-smithy-runtime v1.8.6 -> v1.9.0
    Updating aws-smithy-runtime-api v1.8.7 -> v1.9.0
    Updating bitflags v2.9.1 -> v2.9.2
    Updating cc v1.2.32 -> v1.2.33
    Updating cfg-if v1.0.1 -> v1.0.3
    Updating clap v4.5.44 -> v4.5.45
    Updating clap_derive v4.5.41 -> v4.5.45
 Downgrading crc-fast v1.4.0 -> v1.3.0 (available: v1.4.0)
    Updating curl v0.4.48 -> v0.4.49
    Updating curl-sys v0.4.82+curl-8.14.1 -> v0.4.83+curl-8.15.0
    Updating derive_arbitrary v1.4.1 -> v1.4.2
    Updating filetime v0.2.25 -> v0.2.26
    Updating form_urlencoded v1.2.1 -> v1.2.2
    Updating gix-actor v0.35.3 -> v0.35.4
    Updating gix-fs v0.16.0 -> v0.16.1
    Updating gix-object v0.50.1 -> v0.50.2
    Updating gix-ref v0.53.0 -> v0.53.1
    Updating hyper v1.6.0 -> v1.7.0
    Updating idna v1.0.3 -> v1.1.0
    Updating percent-encoding v2.3.1 -> v2.3.2
    Updating prettyplease v0.2.36 -> v0.2.37
    Updating proc-macro2 v1.0.97 -> v1.0.101
    Updating quick-xml v0.38.1 -> v0.38.2
    Updating rayon v1.10.0 -> v1.11.0
    Updating rayon-core v1.12.1 -> v1.13.0
    Updating reqwest v0.12.22 -> v0.12.23
    Updating serde_json v1.0.142 -> v1.0.143
    Updating syn v2.0.104 -> v2.0.106
    Updating tempfile v3.20.0 -> v3.21.0
    Updating thiserror v2.0.14 -> v2.0.16
    Updating thiserror-impl v2.0.14 -> v2.0.16
    Updating tinyvec v1.9.0 -> v1.10.0
    Updating ureq v3.0.12 -> v3.1.0
    Updating ureq-proto v0.4.2 -> v0.5.0
    Updating url v2.5.4 -> v2.5.6
    Removing webpki-root-certs v0.26.11
    Updating winapi-util v0.1.9 -> v0.1.10
    Updating zip v4.3.0 -> v4.4.0
@syphar syphar changed the title update to rust 1.89.0 run cargo update, update to rust 1.89.0 Aug 21, 2025
@syphar syphar marked this pull request as ready for review August 21, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant