Skip to content

Do not scroll when closing the menu with space #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2020
Merged

Do not scroll when closing the menu with space #1141

merged 2 commits into from
Oct 30, 2020

Conversation

notriddle
Copy link
Contributor

Fixes #1082

@notriddle notriddle force-pushed the master branch 2 times, most recently from 3472953 to c0c6b3f Compare October 30, 2020 00:24
@jyn514 jyn514 added A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Oct 30, 2020
jyn514
jyn514 reviewed Oct 30, 2020
View reviewed changes
@jyn514 jyn514 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 30, 2020
@jyn514 jyn514 merged commit 14f36e9 into rust-lang:master Oct 30, 2020
@jyn514 jyn514 removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-frontend Area: Web frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressing space to close a header menu (navigating with keyboard instead of mouse) will scroll down the page, not just close the menu
2 participants
@notriddle @jyn514