Skip to content

Conversation

@Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Sep 4, 2018

@pietroalbini
Copy link
Member

cargo install lazy_static rightfully fails because there are no lazy_static binaries. You need to ignore the error. LGTM otherwise.

@pietroalbini
Copy link
Member

Rustfmt error (remove the trailing whitespace in the comment at line 172).

@Eh2406
Copy link
Contributor Author

Eh2406 commented Sep 4, 2018

Sorry doing this PR using the github editor.

@pietroalbini
Copy link
Member

Still failing rustfmt :(

@Eh2406
Copy link
Contributor Author

Eh2406 commented Sep 4, 2018

Tried again this time doing only what it says it wants.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Sep 5, 2018

and we are green

@pietroalbini pietroalbini merged commit eaa481a into rust-lang:master Sep 5, 2018
@pietroalbini
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants