quickcheck: better generation of input arguments #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| arbitrary!(I32: i32); |
There was a problem hiding this comment.
I wasn't sure if these should also use the arbitrary_large generation method. Does any intrinsic have special handling of cases where the lower/higher half-word is zero?
|
Ah yes, nice catch in |
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
Also includes implementing the private k_tan function. Closes rust-lang#36
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
110: Implement tan r=japaric a=porglezomp Also includes implementing the private `k_tan` function. Closes rust-lang#36 Co-authored-by: C Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #31
cc @Amanieu tests for muldi and udivdi3 are now failing due to overflows. I've yet to investigate.