Set probestack visibility to hidden on ELF targets #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this lands into master and is confirmed by downstream users as both not breaking anything and fixing the bug, we will likely want to consider a beta backport as well. (Though the regression is stable/stable at this point, so it is less important than for a stable/beta regression, in some sense). |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 12, 2020
…n-DPC Update compiler-builtins to 0.1.25 - rust-lang/compiler-builtins#340 Set probestack visibility to hidden on ELF targets Fixes rust-lang#68794. Tested in CI: rust-lang#69045. r? @Mark-Simulacrum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for rust-lang/rust#68794. Tested across a few different platforms in rust-lang/rust#69045, and it looks like it hasn't broken anything.
cc @Mark-Simulacrum @Amanieu