Intern Vec<ProgramClause<I>> #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
requested changes
Apr 3, 2020
chalk-ir/src/lib.rs
Outdated
|
|
||
| #[derive(Clone, PartialEq, Eq, Hash, PartialOrd, Ord, HasInterner)] | ||
| pub struct ProgramClause<I: Interner> { | ||
| clause: I::InternedProgramClause, |
There was a problem hiding this comment.
Nit: I think we we call this interned in all the other structs
There was a problem hiding this comment.
We call it interned except in Goal and Goals IIRC. I think those should be renamed and everything should be interned.
There was a problem hiding this comment.
It looks like @tirr-c fixed the new cases in this PR, we can create an issue for the others
| pub fn data(&self, interner: &I) -> &ProgramClauseData<I> { | ||
| interner.program_clause_data(&self.clause) | ||
| } | ||
| } |
There was a problem hiding this comment.
Also I think we should add an interned(&self) -> &I::InternedProgramClause accessor
|
Looks like the tests need to be updated, too |
5 tasks
|
@nikomatsakis Done, pushed changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR interns
ProgramClauseandVec<ProgramClause>, and makes changes accordingly.