-
Notifications
You must be signed in to change notification settings - Fork 47
Support cfg(true)
and cfg(false)
#99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These aren’t supported yet there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small test requests. The impl itself looks good to me, but @nnethercote would you mind giving this a second set of eyes? Considering you've been looking at these patterns recently and they can be a bit tricky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok. My only question is how is the behaviour changed if you do something erroneous like if #[cfg(99)]
? Probably a different error message?
Yes, from “no rules expected `<token>` in macro call” to “ |
Sounds good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this slipped off my radar, thanks Nick for taking a look
Released in 1.0.4 |
meta
does not matchtrue
/false
, so switch tott
.