Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 26, 2021

The version string for cargo version was inadvertently changed in #9657 so that it does not include the leading cargo as in cargo 1.53.0 (4369396ce 2021-04-27).

@ehuss ehuss added regression-from-stable-to-beta Regression in beta that previously worked in stable. beta-nominated Nominated to backport to the beta branch. labels Jul 26, 2021
@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2021
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 26, 2021

📌 Commit fdc398e has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2021
@bors
Copy link
Contributor

bors commented Jul 26, 2021

⌛ Testing commit fdc398e with merge d21c228...

@bors
Copy link
Contributor

bors commented Jul 26, 2021

☀️ Test successful - checks-actions
Approved by: alexcrichton
Pushing d21c228 to master...

@bors bors merged commit d21c228 into rust-lang:master Jul 26, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 27, 2021
Update cargo

8 commits in cebef2951ee69617852844894164b54ed478a7da..d21c22870e58499d6c31f1bef3bf1255eb021666
2021-07-22 13:01:52 +0000 to 2021-07-26 20:23:21 +0000
- Fix version string. (rust-lang/cargo#9727)
- Allow publishing from workspace root. (rust-lang/cargo#9559)
- Better msg for wrong position (rust-lang/cargo#9723)
- Stabilize the rustc-link-arg option (rust-lang/cargo#9557)
- Warning when using features in replace (rust-lang/cargo#9681)
- Refactor if let chains to matches! macro (rust-lang/cargo#9721)
- Weather is not nice today.. (rust-lang/cargo#9720)
- Update should_use_metadata function (rust-lang/cargo#9653)
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 27, 2021
Update cargo

8 commits in cebef2951ee69617852844894164b54ed478a7da..d21c22870e58499d6c31f1bef3bf1255eb021666
2021-07-22 13:01:52 +0000 to 2021-07-26 20:23:21 +0000
- Fix version string. (rust-lang/cargo#9727)
- Allow publishing from workspace root. (rust-lang/cargo#9559)
- Better msg for wrong position (rust-lang/cargo#9723)
- Stabilize the rustc-link-arg option (rust-lang/cargo#9557)
- Warning when using features in replace (rust-lang/cargo#9681)
- Refactor if let chains to matches! macro (rust-lang/cargo#9721)
- Weather is not nice today.. (rust-lang/cargo#9720)
- Update should_use_metadata function (rust-lang/cargo#9653)
ehuss pushed a commit to ehuss/cargo that referenced this pull request Jul 27, 2021
Fix version string.

The version string for `cargo version` was inadvertently changed in rust-lang#9657 so that it does not include the leading `cargo` as in `cargo 1.53.0 (4369396 2021-04-27)`.
bors added a commit that referenced this pull request Jul 27, 2021
[Beta] backport version string fix

Beta backport of #9727 for 1.55.
@ehuss ehuss modified the milestones: 1.56.0, 1.55.0 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-nominated Nominated to backport to the beta branch. regression-from-stable-to-beta Regression in beta that previously worked in stable. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants