Fix all Clippy suggestions (but not add it to CI 🙃)#7574

Merged

bors merged 16 commits intorust-lang:masterfrom

igor-makarov:clippy-fixes

Nov 15, 2019

Commits on Nov 12, 2019

add clippy to the pipelines
igor-makarov
committed
remove suppression of clippy lint `too_many_arguments`
igor-makarov
committed
implement clippy suggestion to use `or_insert_with`
igor-makarov
committed
implement clippy suggestion to use `if` as an expression
igor-makarov
committed
implement clippy suggestion to remove needless `return`
igor-makarov
committed
implement clippy suggestion to use `or_else` instead of `or` to avoid unintended side effects
igor-makarov
committed
refactor method to avoid calling `unwrap()` explicitly
igor-makarov
committed
implement clippy suggestion to remove needless `return`
igor-makarov
committed
implement clippy suggestion to remove redundant `to_string`
igor-makarov
committed
suppress clippy lint `needless_doctest_main`
igor-makarov
committed
silence several clippy lints in tests
igor-makarov
committed
implement clippy suggestion not to use `assert_eq` on `()`
igor-makarov
committed
suppress clippy lint `block_in_if_condition_stmt` in the testsuite because fixing it upsets rustfmt
igor-makarov
committed
implement clippy suggestion to remove redundant `clone`
igor-makarov
committed
suppress clippy lint `inefficient_to_string` - according to reviewers' preference
igor-makarov
committed

Commits on Nov 15, 2019

Remove clippy from pipelines - @Eh2406 asked that the commit will be kept
igor-makarov
committed