Skip to content

Conversation

@dwijnand
Copy link
Contributor

@dwijnand dwijnand commented Feb 5, 2019

No description provided.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

r=me w/ green CI

@dwijnand
Copy link
Contributor Author

dwijnand commented Feb 5, 2019

Ah, breaking changes in rand making a (transitive?) dependency on rand_isaacs break. Oh well.

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 11, 2019

This is unfortunate, I was looking forward to using some of the new toys in 0.9.1

@dwijnand
Copy link
Contributor Author

How are problems like this resolved in Rust?

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 11, 2019

It looks like it is just minimal-versions that is not passing. As this is an unstable feature there is not yet much advice on how to fix it. Fundamentally, rand_isaac-0.1.0 is lying about the minimum version of SeedableRng that it supports.

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 12, 2019

From a quick look rand 0.6.x is a hot mess with incorrect minimal-versions.

@dwijnand
Copy link
Contributor Author

Ok I spent a long time trying to make it work, following your guide in #5657 (comment) and reading lots of commits, comments and threads, and couldn't figure it out. If you have an advice I can continue trying.

@Eh2406
Copy link
Contributor

Eh2406 commented Feb 12, 2019

Thanks for spending the time! I spent some time trying to figure it out as well, but did not get far.

Eh2406 added a commit to Eh2406/cargo that referenced this pull request Mar 16, 2019
This is a rework of rust-lang#6636 now possible do to the change in testing from rust-lang#6748
@Eh2406 Eh2406 mentioned this pull request Mar 16, 2019
bors added a commit that referenced this pull request Mar 16, 2019
Proptest 0.9.1

This is a rework of #6636 now possible do to the change in testing from #6748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants