Skip to content

Conversation

@dwijnand
Copy link
Contributor

  • Collapse the nested cargotest::support module into the cargotest
    module (merge the mod.rs's)
  • Rename the cargotest module to support
  • Nest the top-level hamcrest module into support

Fixes #5744

I apologise ahead-of-time to the authors of the PRs this is going to break..

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

🏆

@bors: r+

My hero!

@bors
Copy link
Contributor

bors commented Jul 22, 2018

📌 Commit 566b4c343a2ca2265ed49437d6f4fc64263ee73d has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 22, 2018

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout test-mod-reorg (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self test-mod-reorg --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
Auto-merging tests/testsuite/support/registry.rs
Auto-merging tests/testsuite/support/publish.rs
Auto-merging tests/testsuite/support/mod.rs
Auto-merging tests/testsuite/support/install.rs
Auto-merging tests/testsuite/support/git.rs
Auto-merging tests/testsuite/support/cross_compile.rs
Auto-merging tests/testsuite/run.rs
Auto-merging tests/testsuite/package.rs
CONFLICT (content): Merge conflict in tests/testsuite/package.rs
Removing tests/testsuite/cargotest/mod.rs
Automatic merge failed; fix conflicts and then commit the result.

@bors
Copy link
Contributor

bors commented Jul 22, 2018

☔ The latest upstream changes (presumably #5763) made this pull request unmergeable. Please resolve the merge conflicts.

* Collapse the nested cargotest::support module into the cargotest
  module (merge the mod.rs's)
* Rename the cargotest module to support
* Nest the top-level hamcrest module into support
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 22, 2018

📌 Commit 43b42d6 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 22, 2018

⌛ Testing commit 43b42d6 with merge 6b38295...

bors added a commit that referenced this pull request Jul 22, 2018
Reorganise the testsuite crate module hierarchy

* Collapse the nested cargotest::support module into the cargotest
  module (merge the mod.rs's)
* Rename the cargotest module to support
* Nest the top-level hamcrest module into support

Fixes #5744

I apologise ahead-of-time to the authors of the PRs this is going to break..
@bors
Copy link
Contributor

bors commented Jul 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6b38295 to master...

@bors bors merged commit 43b42d6 into rust-lang:master Jul 22, 2018
@dwijnand dwijnand deleted the test-mod-reorg branch July 22, 2018 19:24
@dwijnand dwijnand mentioned this pull request Aug 7, 2018
6 tasks
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test cleanup: Cargo's testsuite crate module hierarchy is a bit of a mess

5 participants