Skip to content

Conversation

@iKevinY
Copy link
Contributor

@iKevinY iKevinY commented Jul 22, 2017

Unit struct support was added in Docopt 0.8.1 via docopt/docopt.rs#217. Fixes #4174.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matklad
Copy link
Contributor

matklad commented Jul 22, 2017

I think Cargo.toml and Cargo.lock should be modified as well?

Unit struct support was added in Docopt 0.8.1 via
docopt/docopt.rs#217. Fixes #4174.
@iKevinY
Copy link
Contributor Author

iKevinY commented Jul 22, 2017

docopt was already at 0.8.1 in Cargo.lock, but I've gone and updated Cargo.toml.

@matklad
Copy link
Contributor

matklad commented Jul 22, 2017

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 22, 2017

📌 Commit aa4f86f has been approved by matklad

@bors
Copy link
Contributor

bors commented Jul 22, 2017

⌛ Testing commit aa4f86f with merge 88aa642...

bors added a commit that referenced this pull request Jul 22, 2017
Convert Options struct into unit struct

Unit struct support was added in Docopt 0.8.1 via docopt/docopt.rs#217. Fixes #4174.
@bors
Copy link
Contributor

bors commented Jul 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 88aa642 to master...

@bors bors merged commit aa4f86f into rust-lang:master Jul 22, 2017
@ehuss ehuss added this to the 1.21.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove docopt workaround

5 participants