Skip to content

Conversation

@stewart
Copy link

@stewart stewart commented Dec 29, 2016

The #[bench] attribute is currently unstable, and is only usable on nightly Rust.

However, being able to benchmark code with cargo bench is very useful functionality when writing performance-focused code, and something that the Cargo documentation currently glosses over.

Some useful information on how to get benchmark tests up and running, with necessary caveats about stability, would likely be very helpful to new users.

The `#[bench]` attribute is [currently unstable][1], and is only usable
on nightly Rust.

However, being able to benchmark code with `cargo bench` is very useful
functionality when writing performance-focused code, and something that
the Cargo documentation currently glosses over.

Some useful information on how to get benchmark tests up and running,
with necessary caveats about stability, would likely be very helpful to
new users.

[1]: rust-lang/rust#29553
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

Thanks for this! I'm kind of conflicted, as it's not totally clear how stable/unstable stuff should work in Cargo's docs. And about half of this is more about Rust than it is about the cargo bits. Which also isn't bad..... i dunno.

We certainly need to explain this somehow, though.

@bors
Copy link
Contributor

bors commented Feb 2, 2017

☔ The latest upstream changes (presumably #3004) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
Copy link
Member

I'm gonna close this due to inactivity, but feel free to resubmit with a rebase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants