Skip to content

Conversation

@ducks
Copy link
Contributor

@ducks ducks commented Aug 29, 2016

Fixes #3056

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

r? @steveklabnik

@steveklabnik
Copy link
Contributor

Thanks @rjgoldsborough . Two quick questions:

  1. I'm assuming that metadata stuff was added because this is the first time it's been run on a cargo that supports it? @alexcrichton ?
  2. I think I'd like to make some fixes, but I might send a PR to your PR for them. Thoughts on that? You'd merge my PR to your PR, then we'd merge this PR, which would then include the fixes 😄

@ducks
Copy link
Contributor Author

ducks commented Aug 29, 2016

@steveklabnik,

Yeah, I just straight copied all that text so it might need some updating.

But sure. Whatever works for you. Just excited to dive in. :)

And honestly, I'm not sure why that got added heh. It came with the build so I left it.

@steveklabnik
Copy link
Contributor

Sent!

@steveklabnik
Copy link
Contributor

Also, /cc @rust-lang/core , given that this is no longer the literal text of the old post. I've mostly

  1. Removed speculation about future features
  2. Reorganized and added headings
  3. Removed other wording that was better suited for the previous announcement, rather than a more static policies page.

Many questions are specialized instances of a more general form: “Under what
circumstances can a package be removed from Crates.io?”

The short version is that packages are first-come, first-served, and we won’t
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"served"

@alexcrichton
Copy link
Member

@steveklabnik looks good to me!

@aturon
Copy link
Contributor

aturon commented Sep 27, 2016

LGTM

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

thanks! Sorry for the latency here, it's been a busy month!

@bors
Copy link
Contributor

bors commented Sep 28, 2016

📌 Commit a26732c has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Sep 28, 2016

⌛ Testing commit a26732c with merge eaebe26...

bors added a commit that referenced this pull request Sep 28, 2016
@ducks
Copy link
Contributor Author

ducks commented Sep 28, 2016

Yeah for sure, and no problem!

@ducks
Copy link
Contributor Author

ducks commented Sep 28, 2016

And thank y'all!

@bors
Copy link
Contributor

bors commented Sep 28, 2016

💔 Test failed - cargo-win-msvc-64

@alexcrichton
Copy link
Member

@bors: retry

On Tue, Sep 27, 2016 at 6:14 PM, bors [email protected] wrote:

💔 Test failed - cargo-win-msvc-64
https://buildbot.rust-lang.org/builders/cargo-win-msvc-64/builds/662


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3057 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95K79zpK7q1JIdlwYlUGA1pNE5Y1cks5qub9tgaJpZM4JvxGc
.

@bors
Copy link
Contributor

bors commented Sep 28, 2016

⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-msvc-32 are reusable. Rebuilding only cargo-cross-linux, cargo-win-gnu-64, cargo-win-msvc-64...

@bors
Copy link
Contributor

bors commented Sep 28, 2016

☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64
Approved by: steveklabnik
Pushing eaebe26 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants