Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 15, 2024

This is in preparation to publish a new release of the home crate (from the current master branch).

Users should be using the standard library `home_dir` instead of this
crate.
@rustbot
Copy link
Collaborator

rustbot commented Dec 15, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-environment-variables Area: environment variables A-home Area: the `home` crate S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2024
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge it with or without fixing nits

@weihanglo
Copy link
Member

#14940

For example, I would like to create home-0.5.11 tags (and earlier versions that were missed due to this trigger).

Saw this. Assume you are going to release older versions. I am going to merge this now. Thanks!

@weihanglo weihanglo added this pull request to the merge queue Dec 16, 2024
Merged via the queue into rust-lang:master with commit addcc8c Dec 16, 2024
20 checks passed
github-merge-queue bot pushed a commit to smithy-lang/smithy-rs that referenced this pull request Dec 17, 2024
## Description
Seeing preview build failures across the board. Looks like `[email protected]`
was [released a few hours
ago](rust-lang/cargo#14939) and comes with a new
MSRV of 1.81. We don't have a lockfile for `smithy-rs-tool-common` for
some reason. This PR adds one.


```
~/sandbox/rs/smithy-rs/tools/ci-build/smithy-rs-tool-common on main ✗                                                                            [41d648d]  12:14
> cargo check
error: rustc 1.78.0 is not supported by the following package:
  [email protected] requires rustc 1.81
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.78.0
```

Added a lockfile and downgraded `home`:

```sh
> cargo update [email protected] --precise 0.5.9
```

## Testing
Build locally + CI.

## Questions 

Lockfiles do not appear to be updated automatically for anything under
`ci-build` unless I'm missing something. This is probably fine as our
use of lockfiles is intended to catch issues with consumers of
`smithy-rs` and the SDK not our own internal tooling.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

Co-authored-by: Zelda Hessler <[email protected]>
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2024
Update cargo

6 commits in 769f622e12db0001431d8ae36d1093fb8727c5d9..99dff6d77db779716dda9ca3b29c26addd02c1be
2024-12-14 04:27:35 +0000 to 2024-12-18 00:55:17 +0000
- fix(build-std): make Resolve  align to what to build (rust-lang/cargo#14938)
- test(build-std): Isolate output test to avoid spurious `[BLOCKING]` messages from concurrent runs (rust-lang/cargo#14943)
- docs: fix wrong changelog PR link (rust-lang/cargo#14947)
- docs(unstable): Correct stabilization version for MSRV-resolver (rust-lang/cargo#14945)
- Update release information for home 0.5.11 (rust-lang/cargo#14939)
- Limit release trigger to 0.* tags (rust-lang/cargo#14940)
@rustbot rustbot added this to the 1.85.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-environment-variables Area: environment variables A-home Area: the `home` crate S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants