Add git2-curl as a dependency #1285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to libgit2 not supporting HTTP proxies, the custom transport API of the library must be used to reimplement the HTTP transport with proxy support. The git2-curl crate implements this transport on top of the curl-rust crate. By using libcurl we gain all sorts of proxy support for free. This transport is not used by default, however, as it is not well battle tested and the architecture is not currently ideal (download the entire repo into memory on a clone). Only when an HTTP proxy is present is the new transport used. The other drawback of git2-curl is that it does not currently support authentication. If a private git repository is cloned or authentication is required then it will generate an error instead of correctly asking for credentials. Closes rust-lang#636
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Maybe you could add a config option to enable this without a proxy? (I'd be happy to enable it to help test, but setting up a proxy is annoying...) |
|
Unfortunately if you have a proxy then Cargo doesn't work at all because we use git for the index (which even the registry needs). In that sense this is a strict improvement over what we currently have! I've been currently testing with: (using |
|
@bors r+ b20b |
bors
added a commit
that referenced
this pull request
Feb 12, 2015
Due to libgit2 not supporting HTTP proxies, the custom transport API of the library must be used to reimplement the HTTP transport with proxy support. The git2-curl crate implements this transport on top of the curl-rust crate. By using libcurl we gain all sorts of proxy support for free. This transport is not used by default, however, as it is not well battle tested and the architecture is not currently ideal (download the entire repo into memory on a clone). Only when an HTTP proxy is present is the new transport used. The other drawback of git2-curl is that it does not currently support authentication. If a private git repository is cloned or authentication is required then it will generate an error instead of correctly asking for credentials. Closes #636
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to libgit2 not supporting HTTP proxies, the custom transport API of the
library must be used to reimplement the HTTP transport with proxy support. The
git2-curl crate implements this transport on top of the curl-rust crate. By
using libcurl we gain all sorts of proxy support for free.
This transport is not used by default, however, as it is not well battle tested
and the architecture is not currently ideal (download the entire repo into
memory on a clone). Only when an HTTP proxy is present is the new transport
used.
The other drawback of git2-curl is that it does not currently support
authentication. If a private git repository is cloned or authentication is
required then it will generate an error instead of correctly asking for
credentials.
Closes #636