Define HAVE_KERN_PROC on FreeBSD to fix rust-lang/rust#54434 #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the same reason define HAVE_KERN_PROC_ARGS on NetBSD. This depends on having [1] available in libbacktrace. [1] ianlancetaylor/libbacktrace@0f06cda
jbeich
reviewed
Feb 20, 2020
|
To make sure I understand, this needs extra commits in libbacktrace right? If so the submodule here will need an update before merging this. |
|
Yes, it needs ianlancetaylor/libbacktrace@0f06cda which is not yet in rust-lang-nursery/libbacktrace. |
|
Ah ok, then this will need to include a submodule update as well to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with [1] this fixes rust-lang/rust#54434. For the same reason optimistically define HAVE_KERN_PROC_ARGS on NetBSD (untested by me though).
To have any effect this requires [1,2].
[1] ianlancetaylor/libbacktrace@0f06cda
[2] rust-lang/libbacktrace#1