Skip to content

serial: enforce all traits have the same Error type. #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2022
Merged

serial: enforce all traits have the same Error type. #337

merged 1 commit into from
Jan 12, 2022

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Dec 20, 2021

Equivalent of #331 for serial.

@Dirbaio Dirbaio requested a review from a team as a code owner December 20, 2021 21:16
@rust-highfive
Copy link

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

eldruin
eldruin previously approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@Dirbaio Dirbaio force-pushed the serial-error-unify branch from 5b5c791 to 66b27e4 Compare January 11, 2022 22:02
@Dirbaio
Copy link
Member Author

Dirbaio commented Jan 11, 2022

Rebased on latest master.

Friendly ping @eldruin @therealprof @ryankurte are there any pending concerns on this?

therealprof
therealprof approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I've a feeling this might conflict now, though.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 12, 2022

Build succeeded:

@bors bors bot merged commit 34ae853 into rust-embedded:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@eldruin eldruin eldruin left review comments

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dirbaio @rust-highfive @eldruin @therealprof @ryankurte