Skip to content

deprecate ptr() function for the v0.7.x series #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2022
Merged

deprecate ptr() function for the v0.7.x series #386

merged 2 commits into from
Jan 10, 2022

Conversation

TDHolmes
Copy link
Contributor

@TDHolmes TDHolmes commented Jan 6, 2022 •
edited
Loading

Deprecating ptr() in v0.7.x series per #370

@TDHolmes TDHolmes requested a review from a team as a code owner January 6, 2022 22:14
TDHolmes
TDHolmes commented Jan 6, 2022
View reviewed changes
@TDHolmes
Copy link
Contributor Author

TDHolmes commented Jan 6, 2022

ah fun, CI doesn't like deprecated warnings:

  --> panic-itm/src/lib.rs:49:35
   |
49 |     let itm = unsafe { &mut *ITM::ptr() };
   |                                   ^^^
   |
note: the lint level is defined here
  --> panic-itm/src/lib.rs:33:9
   |
33 | #![deny(warnings)]
   |         ^^^^^^^^
   = note: `#[deny(deprecated)]` implied by `#[deny(warnings)]`

@adamgreig
Copy link
Member

I guess we'd better backport that change to panic-itm to 0.7 branch as well, then?

@TDHolmes
Copy link
Contributor Author

TDHolmes commented Jan 9, 2022

yeah wasn't sure what you wanted to do, ignore CI, add an #[allow(deprecated)] or fix. Probably should just fix.

adamgreig
adamgreig approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

bors merge

@bors bors bot merged commit b581ec7 into rust-embedded:v0.7.x Jan 10, 2022
@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TDHolmes @adamgreig