-
Notifications
You must be signed in to change notification settings - Fork 305
Fix release and do another RC: v0.32.0-beta.2
#874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Attribute has been removed in recent nightly toolchain and this breaks the docs build on docsrs.
This function is deprecated and exists to assist the upgrade path, as such the arg order should be the same as in `v0.31.1`.
edf0a35 to
c112580
Compare
v0.32.0-rc.2v0.32.0-beta.2
|
Changed |
|
Super frustrating. My local CI is failing with which I have a local patch which I thought fixed :/. Will prod at it a bit. The test makes sense, we shouldn't have to remove it, and yet it's been so flakey.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c112580; successfully ran local tests
In preparation for doing another RC release bump the version and update the lock files. The changes in this release do not need a changelog entry because they are: - Remove `doc_auto_cfg` - Re-order args in deprecated method we just added already (changelog mentions it already).
c112580 to
5648336
Compare
|
Fixed the commit log, no sure why I didn't do that yesterday. Sorry to make you run CI again. |
|
No worries. My CI box was down for the last 24 hours anyway (moving my homedir from btrfs to ext4). It's nice to have an easy PR to make sure it's back up and running now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK c112580; successfully ran local tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 5648336; successfully ran local tests
|
LFG, soon as this is released I believe we can do the first |
|
Queued. Should be less than an hour. |
|
Tagged and published. |
The changes in this release do not need a changelog entry because they are:
doc_auto_cfgI noticed the arg thing while doing the upgrade in
bitcoinand have tested the change.