Skip to content

Conversation

@tcharding
Copy link
Member

The changes in this release do not need a changelog entry because they are:

  • Remove doc_auto_cfg
  • Re-order args in deprecated method we just added already (changelog mentions it already).

I noticed the arg thing while doing the upgrade in bitcoin and have tested the change.

Attribute has been removed in recent nightly toolchain and this breaks
the docs build on docsrs.
This function is deprecated and exists to assist the upgrade path, as
such the arg order should be the same as in `v0.31.1`.
@apoelstra apoelstra changed the title Fix release and do another RC: v0.32.0-rc.2 Fix release and do another RC: v0.32.0-beta.2 Oct 29, 2025
@apoelstra
Copy link
Member

Changed rc to beta in PR description. Can't edit the commit message but I'll live with it. The code is correct.

@apoelstra
Copy link
Member

Super frustrating. My local CI is failing with

---- key::test::pubkey_hash stdout ----
thread 'key::test::pubkey_hash' panicked at 'assertion failed: !set.contains(&hash)', src/key/mod.rs:1731:13
stack backtrace:
   0: rust_begin_unwind
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/std/src/panicking.rs:584:5
   1: core::panicking::panic_fmt
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/panicking.rs:142:14
   2: core::panicking::panic
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/panicking.rs:48:5
   3: secp256k1::key::test::pubkey_hash
             at /source/src/key/mod.rs:1731:13
   4: secp256k1::key::test::pubkey_hash::{{closure}}
             at /source/src/key/mod.rs:1715:5
   5: core::ops::function::FnOnce::call_once
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/ops/function.rs:248:5
   6: core::ops::function::FnOnce::call_once
             at /rustc/4b91a6ea7258a947e59c6522cd5898e7c0a6a88f/library/core/src/ops/function.rs:248:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

which I have a local patch which I thought fixed :/. Will prod at it a bit. The test makes sense, we shouldn't have to remove it, and yet it's been so flakey..

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c112580; successfully ran local tests

In preparation for doing another RC release bump the version and
update the lock files.

The changes in this release do not need a changelog entry because they
are:

- Remove `doc_auto_cfg`
- Re-order args in deprecated method we just added already (changelog
  mentions it already).
@tcharding
Copy link
Member Author

Fixed the commit log, no sure why I didn't do that yesterday. Sorry to make you run CI again.

@apoelstra
Copy link
Member

No worries. My CI box was down for the last 24 hours anyway (moving my homedir from btrfs to ext4). It's nice to have an easy PR to make sure it's back up and running now.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c112580; successfully ran local tests

@tcharding
Copy link
Member Author

ext4, represent!

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5648336; successfully ran local tests

@tcharding
Copy link
Member Author

LFG, soon as this is released I believe we can do the first bitcoin 0.33.0 RC

@apoelstra
Copy link
Member

Queued. Should be less than an hour.

@apoelstra
Copy link
Member

Tagged and published.

@apoelstra apoelstra merged commit 6e5c556 into rust-bitcoin:master Oct 30, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants