Trivial doc: Warn that serde differs from consensus encoding #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
approved these changes
Jan 10, 2022
Member
|
Sure, though see rust-bitcoin/rust-bitcoin#765 (comment) where I point out that "serde encoding" is not defined by us and can't possibly be "the same as consensus encoding". |
apoelstra
approved these changes
Jan 10, 2022
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…iffers from consensus encoding 52560a92053874957c80307cdcc91ce281732760 Warn that serde differs from consensus encoding (Martin Habovstiak) Pull request description: Addresses rust-bitcoin/rust-bitcoin#756 (comment) ACKs for top commit: apoelstra: ACK 52560a92053874957c80307cdcc91ce281732760 Tree-SHA512: ee56c13dcb0493318f5b59306d6375adb202a5812c4673f0b9abe71fb809b927a74c3fd61aa20fe28fd2176c67f495214bf4da546380dfe9c83b933b02835fff
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…iffers from consensus encoding 52560a92053874957c80307cdcc91ce281732760 Warn that serde differs from consensus encoding (Martin Habovstiak) Pull request description: Addresses rust-bitcoin/rust-bitcoin#756 (comment) ACKs for top commit: apoelstra: ACK 52560a92053874957c80307cdcc91ce281732760 Tree-SHA512: ee56c13dcb0493318f5b59306d6375adb202a5812c4673f0b9abe71fb809b927a74c3fd61aa20fe28fd2176c67f495214bf4da546380dfe9c83b933b02835fff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rust-bitcoin/rust-bitcoin#756 (comment)