Quiet mode and doc fixes #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a "quiet" mode for non-CI usage when we want things to be quick and quiet.
This allows the run_task script to control output even in the extra_test and extra_lint scripts. This might polute the script if a lot of logic is put in the extra_* scripts, but that isn't their intended use.
|
There is already an open issue in rust-bitcoin for the dup deps: rust-bitcoin/rust-bitcoin#4865 |
|
This is hot AF. I love the quiet mode, you rule. I tested this with the whitelist file I posted here: rust-bitcoin/rust-bitcoin#4865 (comment) |
tcharding
approved these changes
Oct 27, 2025
|
@apoelstra do you remember where we put that merge-policy document? The one that has a table with each crate and the merge policy? I don't remember the merge policy here, since we can't use merged changes without a PR to each downstream repo I think we can just one-ack merge? Will give you a few days to look though. |
|
lol, shellcheck hates you @nyonson |
tcharding
approved these changes
Oct 28, 2025
|
utACK b2329b8 |
|
@tcharding I think you can one-ACK merge here. If I'm really concerned about something I can read it before we start using it. |
|
Got it, cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First patch cleans up some docs, the second adds a
MAINTAINER_TOOLS_LOG_LEVELenvironment variable to run the tasks in quiet mode. Went with an env var over a flag to avoid parsing.While testing this locally with rust-bitcoin, I noticed that the
do_dup_depstest is actually failing right now. Is that by design? Here I have updated the task toerrinstead of justsay_errto be more noticeable. But tbh, I am not quite sure the best way to "fix" rust-bitcoin in its current state.