Skip to content

Handle some cases where "]]" appears in a string literal #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Handle some cases where "]]" appears in a string literal #21

wants to merge 3 commits into from

Conversation

@ecstatic-morse
Copy link
Contributor

@ecstatic-morse ecstatic-morse commented Dec 23, 2021

A partial fix for #20.

@ecstatic-morse

This comment has been minimized.

Sign in to view
@ecstatic-morse
Check for double brackets preceded by a quote
84b58f7 
This handles normal cases, but fails on pathological ones commented out
in the test case.
@ecstatic-morse
Handle expect![[]] (no literal) in locate_end
4b37c15
@lnicola
Copy link
Member

lnicola commented Dec 23, 2021

We're almost regex-free in rust-analyzer, I wish we could avoid it here. But we could at least disable its default features to speed up compile times a little.

@ecstatic-morse ecstatic-morse mentioned this pull request Dec 24, 2021
Merged
bors bot added a commit that referenced this pull request Dec 25, 2021
@bors @ecstatic-morse
Merge #23
c60f9a0 
23: Parse string literals to find their length r=matklad a=ecstatic-morse

Fixes #20. A more complete alternative to #21.

Co-authored-by: Dylan MacKenzie <[email protected]>
@matklad matklad closed this Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ecstatic-morse @lnicola @matklad