Skip to content

Support cloning branches #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Support cloning branches #550

merged 1 commit into from
Jun 23, 2025

Conversation

adrianlyjak
Copy link
Contributor

@adrianlyjak adrianlyjak commented Jun 23, 2025

Add support for cloning branches with <url>@<branch-name> syntax

This is somewhat duplicative of our internal work with kubernetes deployments, but nice to have in the meantime. Architecturally, I think maybe moving towards having a way to prepare a container from a git repo, (or at least the files for a generic container), outside of startup, might reduce the duplication and improve startup times

Manually tested on a branch with some tweaks to build from local llama deploy https://github.com/run-llama/llama_deploy/blob/adrian/test-autodeploy/test_autodeploy.sh

@coveralls
Copy link

Coverage Status

coverage: 86.977%. remained the same
when pulling 945519c on autodeploy-branch
into 848030b on main.

@adrianlyjak adrianlyjak requested a review from masci June 23, 2025 01:05
@adrianlyjak adrianlyjak marked this pull request as ready for review June 23, 2025 01:05
Copy link
Member

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can maybe migrate this code into the library at some point, so we can test it and remove some duplication

@masci masci merged commit 69c21a3 into main Jun 23, 2025
10 checks passed
@masci masci deleted the autodeploy-branch branch June 23, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants